protocols/mdns: Removed obsolete lazy static use from mdns #2977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umgefahren
commented
Oct 4, 2022
Contributor
Author
umgefahren
left a comment
umgefahren
left a comment
There was a problem hiding this comment.
Seems correct.
umgefahren
changed the title
mxinden
approved these changes
Oct 4, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Wonderful to see. Thanks for the patch @umgefahren!
umgefahren
added a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Oct 5, 2022
…ibp2p#2977)" This reverts commit da0403d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While implementing #2975 I discovered an unnecessary use of lazy_static. It can be replaced with a
const, since there is const support for the constructor of Ipv4Addr and Ipv6Addr since Rust version1.32.0. This also removes an unnecessary dependency and might result in better performance, although very, very marginal.Links to any relevant issues
None
Open Questions
None.
Change checklist